Documentation

Markers

Table of Contents

Sources/Actions/Admin/ACP.php 2
Sources/Actions/Admin/Languages.php 1
Sources/Actions/Admin/Maintenance.php 1
Sources/Actions/Admin/Smileys.php 2
Sources/Actions/Admin/Subscriptions.php 3
Sources/Actions/AttachmentUpload.php 1
Sources/Actions/Calendar.php 1
Sources/Actions/Feed.php 1
Sources/Actions/FindMember.php 1
Sources/Actions/Groups.php 1
Sources/Actions/Like.php 1
Sources/Actions/Profile/Export.php 1
Sources/Actions/Recent.php 1
Sources/Actions/RequestMembers.php 1
Sources/Actions/Search2.php 1
Sources/Actions/TopicPrint.php 1
Sources/Actions/Unread.php 1
Sources/BBCodeParser.php 1
Sources/Board.php 3
Sources/Cache/CacheApi.php 1
Sources/Cache/CacheApiInterface.php 2
Sources/Category.php 1
Sources/Config.php 1
Sources/Db/APIs/PostgreSQL.php 1
Sources/Db/DatabaseApi.php 1
Sources/Db/DatabaseApiInterface.php 2
Sources/Event.php 3
Sources/PackageManager/PackageManager.php 1
Sources/PersonalMessage/Received.php 1
Sources/PersonalMessage/Search.php 3
Sources/Search/SearchApi.php 4
Sources/Theme.php 1
Sources/Unicode/Utf8String.php 1
Sources/User.php 1
Sources/Verifier.php 1

ACP.php

Type Line Description
TODO 843 see rev. 10406 from 2.1-requests
TODO 1302 see rev. 10406 from 2.1-requests

Languages.php

Type Line Description
TODO 1732 This function could be two functions?

Maintenance.php

Type Line Description
TODO 1494 refactor

Smileys.php

Type Line Description
TODO 2138 to be moved to Subs-Smileys?
TODO 2188 to be moved to Subs-Smileys?

Subscriptions.php

Type Line Description
TODO 1987 This appears to be unused. Remove it?
TODO 2148 refactor away
TODO 2183 refactor outta here

AttachmentUpload.php

Type Line Description
TODO 121 Add a reference to Utils::$context['instances'] as well?

Calendar.php

Type Line Description
TODO 544 .... allow for week or month export files as well?

Feed.php

Type Line Description
TODO 571 get the list of members from Subs-Members.

FindMember.php

Type Line Description
TODO 32 This was already unused in SMF 2.1. Maybe just remove in 3.0?

Groups.php

Type Line Description
TODO 269 use SMF\ItemList

Like.php

Type Line Description
TODO 58 Do delete, insert, and count really need to be sub-actions? They are never used as sub-actions in practice. Instead, they are only ever called internally by the like() method. Moreover, the control flow regarding hooks, etc., assumes that they are only called by like().

Export.php

Type Line Description
TODO 35 Add CSV, JSON as other possible export formats besides XML and HTML?

Recent.php

Type Line Description
TODO 286 Break this up further.

RequestMembers.php

Type Line Description
TODO 29 This is 100% obsolete, but was never officially deprecated. Remove?

Search2.php

Type Line Description
TODO 95 Break this up into separate protected functions.

TopicPrint.php

Type Line Description
TODO 36 Rewrite to use Msg::get() in order to reduce memory load?

Unread.php

Type Line Description
TODO 383 Break this up further.

BBCodeParser.php

Type Line Description
TODO 2503 Should this respect guest_hideContacts?

Board.php

Type Line Description
TODO 30 Refactor MessageIndex.php into an extension of this class.
TODO 1454 Move this? It's not really related to boards.
TODO 2417 Should this be moved somewhere else? It's not really board-related.

CacheApi.php

Type Line Description
TODO 348 Add a reference to Utils::$context['instances'] as well?

CacheApiInterface.php

Type Line Description
TODO 48 Separate existence checking into its own method
TODO 61 Separate deletion into its own method

Category.php

Type Line Description
TODO 29 Make better use of this class in BoardIndex.php.

Config.php

Type Line Description
TODO 2518 Add special handling for objects?

PostgreSQL.php

Type Line Description
TODO 114 This never seem to be used. Remove it?

DatabaseApi.php

Type Line Description
TODO 145 Use auto-detect for MySQL.

DatabaseApiInterface.php

Type Line Description
TODO 156 PostgreSQL requires a $result param, not a $connection.
TODO 289 why is this needed for?

Event.php

Type Line Description
TODO 26 Implement recurring events.
TODO 26 Use this class to represent holidays and birthdays. They're all-day events, after all.
TODO 936 SMF does not yet take advantage of this generator very well. Instead of loading all the events in the range via Event::loadRange(), it would be better to call Event::get() directly in order to reduce memory load.

PackageManager.php

Type Line Description
TODO 107 Add a reference to Utils::$context['instances'] as well?

Received.php

Type Line Description
TODO 32 Rename the pm_recipients table to pm_received. A recipient is a person who receives something, not the thing received, so the table name is misleading.

Search.php

Type Line Description
TODO 33 Allow searching in the sent items folder.
TODO 423 Why not do this the same way as in SearchApi?
TODO 88 Add more here?

SearchApi.php

Type Line Description
TODO 127 Make this aware of languages.
TODO 127 Should blacklist all BBC.
TODO 127 Setting to add custom values?
TODO 127 Maybe only blacklist if they are the only word, or "any" is used?

Theme.php

Type Line Description
TODO 436 get rid of reading $_REQUEST directly

Utf8String.php

Type Line Description
TODO 684 Improve the fallback code we use when the IntlBreakIterator class is unavailable.

User.php

Type Line Description
TODO 590 This doesn't appear to be used anywhere.

Verifier.php

Type Line Description
TODO 195 BEFORE COMMITTING: Can't return errors from constructor.

Search results